Add inputest package #19377
Merged
Add inputest package #19377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v2/internal/input test package provides helpers for writing input related tests. For now it is internal only, but might be exported if we find it helpful in other places.
urso
added
review
Filebeat
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
kvch
approved these changes
Jun 25, 2020
|
Filebeat failed in system test: This PR only adds some helpers that are not used yet. Relavant go tests did run through. |
urso
pushed a commit
to urso/beats
that referenced
this pull request
Jul 7, 2020
(cherry picked from commit f124da8)
2 tasks
urso
pushed a commit
that referenced
this pull request
Jul 8, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change adds the package filebeat/input/v2/internal/inputest.
The inputest package provides helpers for writing input
related tests. For now it is internal only, but might be exported if we
find it helpful in other places.
The current state of the full implementation can be seen here and sample inputs based on the new API.
The full list of changes will include:
This PR only introduces some testing helpers only.
Why is it important?
Add testing support for v2 inputs.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues